Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope is not persisted on Windows #139

Closed
timfish opened this issue Nov 2, 2018 · 4 comments
Closed

Scope is not persisted on Windows #139

timfish opened this issue Nov 2, 2018 · 4 comments

Comments

@timfish
Copy link
Collaborator

timfish commented Nov 2, 2018

Affected versions: >= 0.12.1

Not sure how I missed this before but in both 0.12.1 and 0.13, scope.json is not getting saved in the sentry directory within the app userData directory.

@timfish timfish changed the title Scope is not persisted Scope is not persisted on Windows Nov 2, 2018
@timfish
Copy link
Collaborator Author

timfish commented Nov 2, 2018

'@sentry/utils/store' .flush() is failing and the error is silently swallowed here.

When running the e2e tests, the ignored error is below and I'm guessing the issue is the leading forward slash:

Error: ENOENT: no such file or directory, mkdir '/C:\Users\tim\AppData\Local\Temp\tmp-cjnzaurx00000xslxs26x5zxe\sentry'  
    at fs.mkdirSync (fs.js:872:3)                                                                                                
    at Object.fs.mkdirSync (ELECTRON_ASAR.js:727:16)                                                                             
    at Object.mkdirpSync (C:\Users\tim\Documents\Repositories\sentry-electron\node_modules\@sentry\utils\fs.js:151:18)           
    at Store.flush (C:\Users\tim\Documents\Repositories\sentry-electron\node_modules\@sentry\utils\store.js:68:12)               
    at Immediate._onImmediate (C:\Users\tim\Documents\Repositories\sentry-electron\node_modules\@sentry\utils\store.js:33:15)    
    at runCallback (timers.js:696:18)                                                                                            
    at tryOnImmediate (timers.js:667:5)                                                                                          
    at processImmediate (timers.js:649:5)                                                                                        
    at process.topLevelDomainCallback (domain.js:121:23)                                                                                                          

I think it was broken by this commit (cc. @kamilogorek) because this is not compatible with Windows.

@timfish
Copy link
Collaborator Author

timfish commented Nov 2, 2018

#140 Added a failing test

@kamilogorek
Copy link
Contributor

Related: getsentry/sentry-javascript#1712

@timfish
Copy link
Collaborator Author

timfish commented Nov 27, 2018

This was fixed in v0.14.0.

@timfish timfish closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants