Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minidump upload broken via electron-fetch breaking change #103

Closed
timfish opened this issue Aug 8, 2018 · 0 comments
Closed

Minidump upload broken via electron-fetch breaking change #103

timfish opened this issue Aug 8, 2018 · 0 comments
Assignees

Comments

@timfish
Copy link
Collaborator

timfish commented Aug 8, 2018

[email protected] has a commonjs default export

For [email protected] maybe they changed their build as now the fetch function is a default named export.

This means when installing sentry-electron and electron-fetch resolves to 1.2.x, you will get the following error when trying to upload minidumps:

TypeError: fetch is not a function
    at MinidumpUploader.<anonymous> (\node_modules\@sentry\electron\dist\main\uploader.js:67:40)
    at Generator.next (<anonymous>)
    at \node_modules\@sentry\electron\dist\main\uploader.js:7:71
    at new Promise (<anonymous>)

I've temporarily fixed this in our project by yarn add [email protected]

@HazAT HazAT self-assigned this Aug 9, 2018
@HazAT HazAT closed this as completed in #105 Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants