Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handled data and differentiate between unhandled errors and crashes #1116

Closed
ueman opened this issue Nov 8, 2022 · 6 comments
Closed

Comments

@ueman
Copy link
Collaborator

ueman commented Nov 8, 2022

Description

From getsentry/rfcs#10 (comment), emphasis mine:

The JS SDK team chatted and agreed that as a first step, we will start sending improved (even if not perfect) data somewhere else (TBD where) in the event, so that a) the scale of the problem can be quantified, and b) any backend or UI folks who do eventually pick up that end of the work have example data to work with. (This will likely be somewhere viewable in the JSON but not directly in the UI for the moment, since for now it's really just analytics.)

I'll update here once exactly where and exactly what we'll send is hammered out. Once we do that, maybe other SDKs can do a similar thing.

I really would like to see that in the Dart/Flutter SDKs too.

Relates to

@marandaneto
Copy link
Contributor

@ueman this is a dupe of #456 IMO
Only one SDK needs to have good enough data to understand the problem a bit better, of course the numbers can vary but its still the same thing.
On Flutter side, we can already get this data because we have access to the mechanism type, we know that runZonedGuarded, isolateError, FlutterError and PlatformDispatcher.onError are unhandled, so its already possible.

@marandaneto
Copy link
Contributor

@lobsterkatie let me know if you all work on getsentry/sentry-javascript#6073
Maybe we can align this either way.

@lobsterkatie
Copy link
Member

@ueman this is a dupe of #456 IMO

Is it? That's just about fixing the handled value to reflect reality, whereas this is requesting the dart SDK do what the JS SDK is proposing to do and send one of three states.

@lobsterkatie let me know if you all work on getsentry/sentry-javascript#6073 Maybe we can align this either way.

Sounds good. It's in the backlog, but I'm going to push for it to happen since it'd be nice to get the ball rolling on actually finally fixing this stuff!

@marandaneto
Copy link
Contributor

@lobsterkatie

s it? That's just about fixing the handled value to reflect reality, whereas this is requesting the dart SDK do what the JS SDK is proposing to do and send one of three states.

That's what I meant by looking at Dart/Flutter mechanisms, we already know if it's unhandled and it's not properly set as unhandled (we can query that on Looker -> (total events vs unhandled events not marked as unhandled).
So there's no data to gather here, it's either fix it or not.

@lobsterkatie
Copy link
Member

Ah, I see what you're saying. Thanks.

@smeubank - I know there aren't as many dart users as JS users, but good to know that we can already gather some data on this score!

@marandaneto
Copy link
Contributor

Closed by #456
We still have the RFC open getsentry/rfcs#10 and I will follow up with new issues if this goes forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants