-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ID missing after setting username field #4036
Comments
That's a good catch, @trst74 💯 . Thanks, for pointing this out. I think it would make sense to change the logic to set a userID if no userID is set here to align with Android. sentry-cocoa/Sources/Sentry/SentryClient.m Lines 799 to 808 in 5e579af
Strictly speaking, this is a breaking change, as some people could rely on the current behavior. The next major will happen soon, so we can include it there. |
Thanks a lot ! We'll be waiting :) |
Platform
iOS
Environment
Production, Develop
Installed
Swift Package Manager
Version
8.10.0
Xcode Version
15.1
Did it work on previous versions?
No response
Steps to Reproduce
iOS SDK and android SDK have difference in terms of setting username. ID dissapears from webinterface after setting username on iOS, but staying on android. Example:
Android:
![Снимок экрана 2024-06-04 в 23 40 40](https://private-user-images.githubusercontent.com/44409010/336570342-d22742b3-0249-4222-927f-a5653b14b11d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjI3MjcsIm5iZiI6MTcxOTQyMjQyNywicGF0aCI6Ii80NDQwOTAxMC8zMzY1NzAzNDItZDIyNzQyYjMtMDI0OS00MjIyLTkyN2YtYTU2NTNiMTRiMTFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDE3MjAyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcwMTA3ZTU5ZDZhYzI2MGEwM2Y5YTFlYTUxMWQ3NGQ1YWU1Njk1NGZkMWY5MTc2NDhjNWRmYWNhYTVkYjFhMTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ORge0TgilIst9-liMIro_WvjG5vnlgLtbv4fljwXvuA)
iOS:
![Снимок экрана 2024-06-04 в 23 41 12](https://private-user-images.githubusercontent.com/44409010/336570515-8c24f67d-cc83-4365-a467-ce3e1a97d659.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjI3MjcsIm5iZiI6MTcxOTQyMjQyNywicGF0aCI6Ii80NDQwOTAxMC8zMzY1NzA1MTUtOGMyNGY2N2QtY2M4My00MzY1LWE0NjctY2UzZTFhOTdkNjU5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDE3MjAyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZjNTA3ZTEwNmVjMDU5ZThjNzRkNWRkOGFiYjY2MTE4YjgxZWIwYzcwNTM5YmZlYjA0NGY4NTRlOTY5NGExMWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.wRGsVGyV_KAoIsLGQbPx-kQkb35Hv5rhE4iYeqSmKGQ)
There is ID field missing on iOS, and naming of fields is different after setting username. As i suppose if ID not set, we have fallback to installationID (which not work for some reason on iOS?..)
Expected Result
ID field still present, after setting username or other User fields.
Actual Result
ID field missing.
Are you willing to submit a PR?
No response
The text was updated successfully, but these errors were encountered: