Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 24.2.0 #2714

Closed
18 tasks done
Tracked by #224
azaslavsky opened this issue Jan 16, 2024 · 12 comments
Closed
18 tasks done
Tracked by #224

Release 24.2.0 #2714

azaslavsky opened this issue Jan 16, 2024 · 12 comments
Assignees

Comments

@azaslavsky
Copy link
Contributor

azaslavsky commented Jan 16, 2024

24.1.2 | 24.2.0 | 24.3.0

@azaslavsky azaslavsky mentioned this issue Jan 17, 2024
18 tasks
@azaslavsky azaslavsky pinned this issue Jan 17, 2024
@aldy505
Copy link
Collaborator

aldy505 commented Jan 25, 2024

As we have some PRs that modifies the sentry/sentry.conf.py file, I think it'd be best to tell everyone on the release notes (on repo's release page) that they need to check and do a diff between the previous version to update their sentry/sentry.conf.py file.

@hubertdeng123
Copy link
Member

@aldy505 yeah you're right, thanks for the callout

@hubertdeng123 hubertdeng123 mentioned this issue Jan 26, 2024
18 tasks
@aldy505
Copy link
Collaborator

aldy505 commented Jan 30, 2024

@hubertdeng123 some people are still missing that notes. See #2744 (comment) for one

cc @chadwhitacre

@chadwhitacre
Copy link
Member

We need to get something in to fix up sentry.conf.py automatically prior to 24.2.0. We should rewrite the conf file automatically if it contains the default value, and we should report on what we did (whether rewrite or skip).

@chadwhitacre
Copy link
Member

Reposted on #2728 and putting that in the TODO here.

@williamdes
Copy link
Contributor

williamdes commented Jan 30, 2024

We need to get something in to fix up sentry.conf.py automatically prior to 24.2.0. We should rewrite the conf file automatically if it contains the default value, and we should report on what we did (whether rewrite or skip).

I my workflow I merge each release tag of this repo into my fork of this repo. The difference is that on my branch I have the final sentry.conf.py. Maybe add an opt out flag so people using their own config file can keep it unchanged? Or for example read only file systems.

@aldy505
Copy link
Collaborator

aldy505 commented Jan 31, 2024

We need to get something in to fix up sentry.conf.py automatically prior to 24.2.0. We should rewrite the conf file automatically if it contains the default value, and we should report on what we did (whether rewrite or skip).

I'm not really good with Python but can we have 2 Python files that's merged or something?

  • sentry.conf.py -> contains the changes needed. at the end of the file it imports the override file and replaces any exported variables.
  • sentry.conf.override.py -> git ignored, custom config by users

Something similar to docker-compose and docker-compose.override maybe?

@chadwhitacre
Copy link
Member

chadwhitacre commented Feb 1, 2024

Maybe add an opt out flag so people using their own config file can keep it unchanged?

I'd be up for conf layering, not sure if we can get that done before the release.

@aldy505
Copy link
Collaborator

aldy505 commented Feb 1, 2024

Also, this: #2751

Should be documented on sentry.conf.py

@chadwhitacre
Copy link
Member

Sorry ... crossed wires. :)

Maybe add an opt out flag so people using their own config file can keep it unchanged?

I'd prefer not to add a flag to avoid complexity. If you have the updated value (PyMemcache or whatever) in your branch then a rewrite script under install.sh should be a no-op, right?

I'm not really good with Python but can we have 2 Python files that's merged or something?

I'd be up for conf layering, not sure if we can get that done before the release.

@williamdes
Copy link
Contributor

I'd prefer not to add a flag to avoid complexity. If you have the updated value (PyMemcache or whatever) in your branch then a rewrite script under install.sh should be a no-op, right?

If it is a sed replaced sure, but is it is a file replacement then it will create some bugs
In my file I added more stuff from ENVs

@chadwhitacre
Copy link
Member

Yeah I'm thinking sed.

@hubertdeng123 hubertdeng123 mentioned this issue Feb 8, 2024
20 tasks
@azaslavsky azaslavsky mentioned this issue Feb 15, 2024
19 tasks
@azaslavsky azaslavsky self-assigned this Feb 16, 2024
@hubertdeng123 hubertdeng123 unpinned this issue Mar 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Archived in project
Development

No branches or pull requests

5 participants