Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Uninstall #7

Open
vdice opened this issue Jan 2, 2019 · 4 comments
Open

Implement Uninstall #7

vdice opened this issue Jan 2, 2019 · 4 comments
Labels
backlog enhancement New feature or request
Milestone
1.0 Fully Baked I...

Comments

@vdice
Copy link
Member

vdice commented Jan 2, 2019

Implement uninstall functionality via uninstall.go
@vdice vdice added the enhancement New feature or request label Jan 2, 2019
@jeremyrickard
Copy link
Contributor

I think this has been fixed already by 237b4f5.

@vdice
Copy link
Member Author

vdice commented Jan 22, 2019

@jeremyrickard I'm not seeing an uninstall implementation in that linked commit... https://github.com/deislabs/porter-azure/blob/master/pkg/azure/uninstall.go still shows just return nil.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 22, 2019 •
edited
Loading

@vdice I commented on the wrrrrrrrrronnnnnnng issue :)

@jeremyrickard
Copy link
Contributor

I am working on a PR for this though! I had both issues open, hence my bad commenting :)

@vdice vdice mentioned this issue Jan 23, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog enhancement New feature or request
Projects
None yet
Milestone
1.0 Fully Baked Implementations
Development

No branches or pull requests
3 participants
@carolynvs @vdice @jeremyrickard