Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the map style from map screens #6037

Open
seadowg opened this issue Mar 25, 2024 · 4 comments
Open

Allow changing the map style from map screens #6037

seadowg opened this issue Mar 25, 2024 · 4 comments
Milestone

Comments

@seadowg
Copy link
Member

seadowg commented Mar 25, 2024

Currently, you can only change the map style ("Google maps style" for the "Google" source for instance) from Maps settings. If the user needs to change map settings while on an actual map, they have to leave the screen their on navigate to Maps settings and then navigate back to the original screen they were on.

We should provide a way to switch styles on all maps screen in a similar way to apps like Google Maps.

@github-project-automation github-project-automation bot moved this to not ready in ODK Collect Mar 25, 2024
@seadowg seadowg added this to the v2024.3 milestone Mar 25, 2024
@alyblenkin
Copy link
Collaborator

alyblenkin commented Apr 25, 2024

@seadowg - I think this would be so helpful for folks. Are you imagining that the user would use the layers icon to select a reference layer or switch map style?

Do the different map sources supply the generic map type images or would we have to create this?

@seadowg
Copy link
Member Author

seadowg commented May 10, 2024

I think this would be so helpful for folks. Are you imagining that the user would use the layers icon to select a reference layer or switch map style?

Potentially both? It could be that there is a separate button for layers and style though. Each map engine has several different styles.

@alyblenkin
Copy link
Collaborator

Let's chat more about this when we pair next week!

@alyblenkin
Copy link
Collaborator

Notes from my chat with @seadowg:

  • We talked about adding a new icon for the map styles, but we think that would be more confusing because the layers icon is pretty universal for changing the map style
  • Start by adding map settings into the bottom sheet with reference layers
  • Display the radio buttons for the map styles (without visual map styles) for now, and then creating our own since there aren't open-source images we can use
  • We would likely implement changing the map styles from the map view first, and then introduce changing the source later.

Next steps:

  • I will work on the flow for changing both the source and map style from the bottom sheet, and then we can determine the best way to implement it.
  • Determine when we want to prioritize creating our own map style assets, which I think will be very helpful but will take time to create

@seadowg seadowg modified the milestones: v2024.3, v2024.4 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: later
Development

No branches or pull requests

2 participants