Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When there are 2 audio widgets on a field-list the sound which is playing has a malfunctioning seekbar when another sound recording starts. #5989

Open
dbemke opened this issue Feb 26, 2024 · 2 comments · Fixed by #5992
Milestone

Comments

@dbemke
Copy link

dbemke commented Feb 26, 2024

ODK Collect version

the store version 2024.1.1, the master version 8c72f97

Android version

10, 14

Device used

Redmi 9T, Pixel 7a

Problem description

It’s possible to play a recorded sound and record a sound at the same time when there are two audio widgets on a field-list and the sound which is playing gets to the moment when the other audio started recording and the slider in the seekbar moves forward and backwards.
The issue doesn’t occur in the 2023.3.1 ( possible to record sound and play sound at the same time but when the sound which is playing the slider in the seekbar doesn't move forwards and backwards).

Steps to reproduce the problem

  1. Go to AllQ410withoutText form.
    AllQ4190withoutText.xml.txt
  2. Record sound in "audio 1” question (e.g. 20 seconds).
  3. Play the recorded sound (e.g. 5 seconds of the sound).
  4. While the sound is playing record sound in "audio 2” question.
  5. Check what happens in audio 1 question.

Expected behavior

When the sound is playing the seekbar shouldn't go forward and backwards.

@seadowg seadowg added this to the v2024.1.x milestone Feb 27, 2024
@grzesiek2010 grzesiek2010 self-assigned this Feb 27, 2024
@dbemke dbemke changed the title When there are 2 audio widgets on a field-list the sound which is playing is stopped and replayed when another sound recroding starts. When there are 2 audio widgets on a field-list the sound which is playing has a malfunctioning seekbar when another sound recording starts. Feb 28, 2024
@grzesiek2010 grzesiek2010 mentioned this issue Feb 28, 2024
5 tasks
@seadowg
Copy link
Member

seadowg commented Mar 4, 2024

Reopened by revert (#5999)

#5992 (comment) was the regression caused by the reverted PR.

@seadowg seadowg reopened this Mar 4, 2024
@seadowg seadowg modified the milestones: v2024.1.x, v2024.2 Mar 4, 2024
@seadowg
Copy link
Member

seadowg commented Mar 4, 2024

Moving this to v2024.2 rather than a hotfix as we're seeing a lot of regressions with audio and I don't want to add any pressure to this. It's likely that we need better testing in AudioClipViewModel - I'd be interested to replace the MediaPlayer mock with a fake for catching more problems with how we transition through states there.

@seadowg seadowg modified the milestones: v2024.2, v2024.3 Apr 4, 2024
@seadowg seadowg modified the milestones: v2024.3, Later Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: not ready
Development

Successfully merging a pull request may close this issue.

3 participants