Eviction tool proof of concept #51
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okdistribute
requested review from
magicwave,
bplattenburg,
kndoshn and
texasRanger09
okdistribute
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see this in action, go to Settings and click Eviction. Eric wrote this, I just merged it in and resolved conflicts.
This also updates the app to 4.7.2.
See the README here for more details and caveats about this feature: https://github.com/getditto/demoapp-pos-guide
This could also be extracted into it's own tool, but I wanted to see what it felt like inside of an application first.
Resolves #29