Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in "unused database settings" ! #23

Open
plyusninva opened this issue Aug 15, 2018 · 5 comments
Open

bug in "unused database settings" ! #23

plyusninva opened this issue Aug 15, 2018 · 5 comments

Comments

@plyusninva
Copy link

plyusninva commented Aug 15, 2018

According to the condition in the line below, the "slick_slider_settings" setting in the database will be deleted, because the files in this plugin are stored in the "/plugins/peterhegman/slickslider/" folder, and not in the "/plugins/slick/slider/" as checked by you.

if ($name[0] != 'backend' && $name[0] != 'system' && isset($name[2]) && !File::exists(base_path().'/plugins/'.$name[0].'/'.$name[1]) && Items::where('path', $row->item)->count() == 0) {

Here is the link to the plugin https://octobercms.com/plugin/peterhegman-slickslider (https://github.com/phegman/October-CMS-Slick-Slider)

@gergo85
Copy link
Owner

gergo85 commented Aug 16, 2018

Thank you for report this bug! I will fix it.

@gergo85
Copy link
Owner

gergo85 commented Aug 22, 2018

I fixed this issue. Please update the plugin!

@gergo85 gergo85 closed this as completed Aug 22, 2018
@plyusninva
Copy link
Author

this does not solve the problem, there are hundreds of such plugins.

@plyusninva plyusninva changed the title maybe bug in "unused database settings" bug in "unused database settings" ! Aug 27, 2018
@gergo85 gergo85 reopened this Aug 28, 2018
@gergo85
Copy link
Owner

gergo85 commented Aug 28, 2018

I will find a better solution.

@gergo85
Copy link
Owner

gergo85 commented Oct 8, 2018

I checked a lot of popular plugins. The most of them use the correct settings code, so I just added more exceptions for database search feature for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants