Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codebase cleanliness tools #123

Open
jisantuc opened this issue Jun 7, 2019 · 1 comment
Open

Add codebase cleanliness tools #123

jisantuc opened this issue Jun 7, 2019 · 1 comment

Comments

@jisantuc
Copy link
Contributor

jisantuc commented Jun 7, 2019 •
edited
Loading

This project is becoming unusual in its ambivalence about format / what gets packaged. We've gotten a lot of mileage (and smaller jars) out of delegating a lot of maintenance work to the compiler and sbt plugins. We should enable the following:

  • scalafmt
  • sbtExplicitDependencies
  • -Xfatal-warnings

, add the checks to ci, and deal with the fallout
@pomadchin
Copy link
Member

We adopted Scalafmt already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pomadchin @jisantuc