You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In subroutine Config_ReadFile from hco_config_mod, passing an unassociated HcoConfig argument is permitted - the subroutine calls ConfigInit on the programmer's behalf, without passing the optional argument nModelSpecies (which is explicitly passed when ConfigInit is called from HCOI_GC_Init, for example):
! Initialize config object if not already initialized
IF ( .NOT. ASSOCIATED(HcoConfig) ) THENCALL ConfigInit( HcoConfig, RC )
HcoConfig%ConfigFileName =TRIM(ConfigFile)
ENDIF
Is there ever a case wherein Config_ReadFile should be called with an unassociated HcoConfig? If not, does the implicit initialisation of the HEMCO config object mask an error state?
The text was updated successfully, but these errors were encountered:
yantosca
changed the title
Potentially masked error state [1] in Config_ReadFile, hco_config_mod
[BUG/ISSUE] Potentially masked error state [1] in Config_ReadFile, hco_config_mod
Nov 12, 2019
This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.
Wondering about your thoughts on this:
In subroutine
Config_ReadFile
fromhco_config_mod
, passing an unassociatedHcoConfig
argument is permitted - the subroutine callsConfigInit
on the programmer's behalf, without passing the optional argumentnModelSpecies
(which is explicitly passed whenConfigInit
is called fromHCOI_GC_Init
, for example):Is there ever a case wherein
Config_ReadFile
should be called with an unassociatedHcoConfig
? If not, does the implicit initialisation of the HEMCO config object mask an error state?The text was updated successfully, but these errors were encountered: