Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] Potentially masked error state [1] in Config_ReadFile, hco_config_mod #28

Closed
kilicomu opened this issue Nov 9, 2019 · 2 comments
Assignees
Labels
category: Bug Something isn't working stale No recent activity on this issue

Comments

@kilicomu
Copy link
Contributor

kilicomu commented Nov 9, 2019

Wondering about your thoughts on this:

In subroutine Config_ReadFile from hco_config_mod, passing an unassociated HcoConfig argument is permitted - the subroutine calls ConfigInit on the programmer's behalf, without passing the optional argument nModelSpecies (which is explicitly passed when ConfigInit is called from HCOI_GC_Init, for example):

! Initialize config object if not already initialized
IF ( .NOT. ASSOCIATED(HcoConfig) ) THEN
   CALL ConfigInit( HcoConfig, RC )
   HcoConfig%ConfigFileName =  TRIM(ConfigFile)   
ENDIF

Is there ever a case wherein Config_ReadFile should be called with an unassociated HcoConfig? If not, does the implicit initialisation of the HEMCO config object mask an error state?

@yantosca yantosca changed the title Potentially masked error state [1] in Config_ReadFile, hco_config_mod [BUG/ISSUE] Potentially masked error state [1] in Config_ReadFile, hco_config_mod Nov 12, 2019
@msulprizio msulprizio transferred this issue from geoschem/geos-chem Mar 31, 2020
@yantosca yantosca added the category: Bug Something isn't working label Jan 13, 2021
@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale No recent activity on this issue label Mar 19, 2021
@stale
Copy link

stale bot commented Mar 26, 2021

Closing due to inactivity

@stale stale bot closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working stale No recent activity on this issue
Projects
None yet
Development

No branches or pull requests

3 participants