Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/ISSUE] HCO_MISSVAL is incorrect for GCHP/GEOS which use MAPL #172

Closed
lizziel opened this issue Oct 18, 2022 · 4 comments
Closed

[BUG/ISSUE] HCO_MISSVAL is incorrect for GCHP/GEOS which use MAPL #172

lizziel opened this issue Oct 18, 2022 · 4 comments
Assignees
Labels
category: Bug Something isn't working
Milestone

Comments

@lizziel
Copy link
Contributor

lizziel commented Oct 18, 2022

HEMCO assigns parameter HCO_MISSVAL (-1e31 float) to denote missing values. If HEMCO handles file read, all missing value grid cells are assigned value HCO_MISSVAL and those grid cells are later skipped during regrid interpolation. During HEMCO run, missing data are then specially handled during scaling and masking.

This works for models in which HEMCO handles the file read and regridding, but not for other models if they assign a different value to missing data. This is the case for GCHP and GEOS which use MAPL's missing value parameter MAPL_UNDEF, equal to 1e15 float. A temporary kludge was put in back in 2017 for masking in GCHP, but was not extended to scale factors, and mostly went unused because MAPL did not use the _FillValue attribute to identify missing values. Instead, MAPL expected missing values to have data values 1e15 in the input files as regular data or assumed _FillValue was 1e15.

The fix is to set HCO_MISSVAL to the MAPL_UNDEF value in HEMCO. A separate fix will be applied to MAPL to identify missing values from netCDF _FillValue attribute without any assumption of what that value is.

This issue is fixed HEMCO in #171.

Heads up @jimmielin that we should keep an eye out for whether there are any missing value handling issues in CESM or WRF-GC.

@lizziel lizziel added the category: Bug Something isn't working label Oct 18, 2022
@lizziel lizziel added this to the 3.5.1 milestone Oct 18, 2022
@lizziel lizziel self-assigned this Oct 18, 2022
@jimmielin
Copy link
Collaborator

Thanks @lizziel. Copying @fengx7 for WRF-GC as well. We follow the handling in the GEOS-Chem Classic code as we use the same libraries so hopefully we won't have to do anything extra to be consistent with other model(s).

@lizziel
Copy link
Contributor Author

lizziel commented Oct 18, 2022

As long as we are using HEMCO to read and regrid we should be good.

@stale
Copy link

stale bot commented Dec 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale No recent activity on this issue label Dec 3, 2022
@lizziel lizziel removed the stale No recent activity on this issue label Dec 5, 2022
@msulprizio msulprizio added the never stale Never label this issue as stale label Dec 5, 2022
@msulprizio msulprizio removed the never stale Never label this issue as stale label Jan 5, 2023
@msulprizio
Copy link
Contributor

The fix for this is now merged (see #171). I will close out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants