Add placeholder error messages where currently there are none #127
Conversation
A quick pass with a shell script to attempt to replace empty error messages with at least somewhat meaningful messages. The `LOC` variable is not defined in various subroutines, and requires adding to those routines to progress.
I only just noticed the `!Initialize` section - sorry!
|
@kilicomu, thanks for taking this!! |
|
That's the calls to |
kilicomu
changed the title
|
Heads up our 13.4.0 code freeze date is this coming Friday. Any chance this could be ready by then? No pressure. It could also go into a 13.4.Z since it will not change benchmark output. |
|
Sure thing - I'll try do it today and mark it ready for you to review. |
|
Okay, I think this is ready for you guys to take a look at. I should say that I think there's more to be done in cleaning up the HEMCO error handling, as there is a lot of duplication of messages and inconsistencies throughout. Also, this PR doesn't add any meaningful messages where it adds new error messages, so those will need to be added at some point. I think we all know about the above problems though, so hopefully this is a step in the right direction and we can talk about a strategy for further improving the error handling at the next software engineering meeting. |
|
Cool - drop me a line if anything turns awry with this and I'll pick it up! |
|
Will run integration tests so we'll know if there are issues. Thanks @kilicomu! |
|
GEOS-Chem integration tests all passed, except for TOMAS40 (as explained in geoschem/geos-chem#1101) gc_4x5_fullchem_TOMAS40_merra2_47L...............Execute Simulation.....FAIL
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 47
Execution tests failed: 1
Execution tests not yet completed: 0GCHP integration tests all passed: ==============================================================================
GCHP: Execution Test Results
Number of execution tests: 3
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gchp_fullchem_benchmark_merra2_c48...............Execute Simulation.....PASS
gchp_fullchem_standard_merra2_c24................Execute Simulation.....PASS
gchp_TransportTracers_geosfp_c24.................Execute Simulation.....PASS
Summary of execution test results:
------------------------------------------------------------------------------
Execution tests passed: 3
Execution tests failed: 0
Execution tests not completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
A quick pass with a shell script to attempt to replace empty error messages with at least somewhat meaningful messages.
The
LOCvariable is not defined in various subroutines, and requires adding to those routines to progress.Closes #126