Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Emissions collection with lev positive up #115

Open
lizziel opened this issue Jul 14, 2021 · 7 comments
Open

Output Emissions collection with lev positive up #115

lizziel opened this issue Jul 14, 2021 · 7 comments
Assignees
Labels
category: Feature Request New feature or request topic: Diagnostics Related to output diagnostic data topic: Usability Related to how user-friendly the model is
Milestone

Comments

@lizziel
Copy link
Contributor

lizziel commented Jul 14, 2021

GCHP has always output the emissions diagnostic collection with levels inverted relative to all other diagnostic collections. Most emissions are 2D so this is not relevant for most emission outputs. However, for 3D emissions the convention difference is a pain for post-processing. It also can be a source of error if users are not aware of the difference from other diagnostics.

The lev positive down convention for HEMCO diagnostics originated in its use in GEOS which always stores and outputs variables with that convention. Changing it to lev positive up should be a straightforward change. The existing code for lev positive down should be kept but put into a MODEL_GEOS cpp ifdef.

@lizziel lizziel added the category: Feature Request New feature or request label Jul 14, 2021
@lizziel
Copy link
Contributor Author

lizziel commented Jul 14, 2021

@lizziel
Copy link
Contributor Author

lizziel commented Jul 20, 2021

If feature request GEOS-ESM/MAPL#914 is implemented as proposed then no work would actually need to be done for this feature request beyond changing HISTORY.rc to specify up for Emissions collection. No changes to HEMCO would be required.

@lizziel
Copy link
Contributor Author

lizziel commented Aug 20, 2021

Specifying lev positive up or down in history files is now possible in MAPL 2.8.3. When this will go into GCHP is still TBD.

@lizziel lizziel added this to the 14.0.0 milestone Dec 15, 2021
@lizziel lizziel self-assigned this Dec 15, 2021
@lfreese
Copy link

lfreese commented Apr 18, 2022

Hi @lizziel --Just checking in to make sure I've understood the relevant threads to this correctly (followed issues #112 and #10 here): if I'm using v 13.2.1, GEOSChem.Emissions collection output will have the surface at lev = 72, and toa at lev = 1; whereas all other collections (eg: SpeciesConc, AerosolMass, etc) have surface at lev = 1 and toa at lev = 72?

@lizziel
Copy link
Contributor Author

lizziel commented Apr 19, 2022

Yes, that is correct! The restart file is also flipped relative to the other diagnostics.

@lizziel lizziel modified the milestones: 14.0.0, 14.1.0 May 25, 2022
@lizziel
Copy link
Contributor Author

lizziel commented May 25, 2022

This update is being moved to the 14.1 release.

@lizziel lizziel added topic: Usability Related to how user-friendly the model is topic: Diagnostics Related to output diagnostic data labels Jun 24, 2022
@lizziel
Copy link
Contributor Author

lizziel commented Sep 27, 2022

I wonder if we should push this to 15.0 since it will break GCPy and maybe is more appropriate for a major release.

@lizziel lizziel modified the milestones: 14.1.0, 15.0.0 Oct 4, 2022
@lizziel lizziel changed the title [FEATURE REQUEST] Output Emissions collection with lev positive up Output Emissions collection with lev positive up Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Diagnostics Related to output diagnostic data topic: Usability Related to how user-friendly the model is
Projects
None yet
Development

No branches or pull requests

2 participants