Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO procedure for if/when OMIM CURIE/identifier changes to "MIM" #2238

Open
kltm opened this issue Feb 14, 2024 · 10 comments
Open

GO procedure for if/when OMIM CURIE/identifier changes to "MIM" #2238

kltm opened this issue Feb 14, 2024 · 10 comments

Comments

@kltm
Copy link
Member

kltm commented Feb 14, 2024

I've been asked to provide feedback on OMIM changing its CURIEs to "MIM".

Looking at the primary GO upstream data (GAFs and GPADs), there does not appear to be any OMIM data that would need to be cleansed. I.e. reset && zgrep -i 'omim:' *-src.*.gz returns nothing.

Looking at our own curation store (GO-CAMs), there is a single reference in a single model (http:https://noctua.geneontology.org/editor/graph/gomodel:55caf38600000003), which is an "experimental" model, unpublished, and almost a decade old. I.e. reset && grep -i 'omim:' *.ttl returns one thing.

Looking at our metadata, we have OMIM listed, but that could likely just be updated (

- database: OMIM
).

Overall, I do not believe there would be any noticeable effect on the GO.

@kltm
Copy link
Member Author

kltm commented Feb 14, 2024

I don't believe we have any real reason to care one way or another about this. Tagging @cmungall and @pgaudet .

@balhoff
Copy link
Member

balhoff commented Feb 14, 2024

There seem to be 4 definition xrefs in the ontology using OMIM:.

@kltm
Copy link
Member Author

kltm commented Feb 14, 2024

@balhoff Ah, that's worth keeping an eye on. (I'm not sure why I blanked on the ontology when grepping...)
Still, a relatively easy "fix" with little propagation, right?

@kltm
Copy link
Member Author

kltm commented Feb 14, 2024

Changing the issue slightly as there should be some action if/when this goes forward.

@kltm kltm changed the title Confirm that GO has no concern about the OMIM CURIE/identifier change to "MIM" GO procedure for if/when OMIM CURIE/identifier changes to "MIM" Feb 14, 2024
@kltm
Copy link
Member Author

kltm commented Feb 14, 2024

@sierra-moxon Is there an upstream issue to watch here?

@balhoff
Copy link
Member

balhoff commented Feb 14, 2024

@balhoff Ah, that's worth keeping an eye on. (I'm not sure why I blanked on the ontology when grepping...) Still, a relatively easy "fix" with little propagation, right?

Very easy update.

@sierra-moxon
Copy link
Member

At the moment, bioregistry requires the prefix to be "omim" -- the discussion to change that in bioregistry is here: biopragmatics/bioregistry#497

In other groups trying to be compliant with bioregistry prefix declarations, waiting until it changes in bioregistry is important. But, from the generators of the identifiers and owners of that namespace, they do seem to make it clear that want MIM to be the prefix.

@cmungall
Copy link
Member

The ontology xrefs should be easy to fix and of course we'd keep OMIM as a synonym.

IMO OMIMs would be a good source of IMPs especially for biochemical phenotypes but looks like we get most of this in human via IEA anyway

@pgaudet
Copy link
Contributor

pgaudet commented Feb 15, 2024

OK for me either way.

@pgaudet
Copy link
Contributor

pgaudet commented Feb 15, 2024

@cmungall Should we delete this model? http:https://noctua.geneontology.org/editor/graph/gomodel:55caf38600000003 ? (created by you)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants