Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify gorule-0000002 to also include No NOT annotations to 'GO:0005488 binding' #2079

Closed
pgaudet opened this issue Sep 28, 2023 · 3 comments
Closed

Modify gorule-0000002 to also include No NOT annotations to 'GO:0005488 binding' #2079

pgaudet opened this issue Sep 28, 2023 · 3 comments
Assignees
@mugitty
Labels
annotation rule
Projects
GORULES (low-hanging fruit)

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Sep 28, 2023 •
edited
Loading

In addition to GO:0005515 (protein binding), NOT GO:0005488 binding should not be allowed
@pgaudet
Copy link
Contributor Author

pgaudet commented Sep 28, 2023

PR here: #2080

to me merged when the change in rule is implemented

@pgaudet pgaudet added this to In progress in GORULES (low-hanging fruit) Sep 28, 2023
@pgaudet pgaudet moved this from In progress to To spec out & prioritize in GORULES (low-hanging fruit) Sep 28, 2023
@pgaudet pgaudet moved this from To spec out & prioritize to TODO in GORULES (low-hanging fruit) Sep 28, 2023
@pgaudet pgaudet mentioned this issue Sep 28, 2023
Closed
@pgaudet pgaudet moved this from TODO to In progress in GORULES (low-hanging fruit) Oct 11, 2023
@dustine32 dustine32 mentioned this issue Oct 13, 2023
Merged
@pgaudet
Copy link
Contributor Author

pgaudet commented Nov 6, 2023 •
edited
Loading

  • Test 2 still is not failing (no NOT annotation to 'binding' )
  • Spaces are not parsed correctly: in the error message:

GORULE:0000002: No 'NOT' annotations to 'protein binding ; GO:0005515'

@pgaudet pgaudet changed the title Modify gorule-0000002 : No NOT annotations to 'GO:0005488 binding' Modify gorule-0000002 to also include No NOT annotations to 'GO:0005488 binding' Nov 6, 2023
@pgaudet
Copy link
Contributor Author

pgaudet commented Nov 7, 2023

Both tests are correctly failing.

@pgaudet pgaudet closed this as completed Nov 7, 2023
@pgaudet pgaudet moved this from In progress to Done in GORULES (low-hanging fruit) Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mugitty mugitty

Labels
annotation rule
Projects
GORULES (low-hanging fruit)
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgaudet @mugitty