-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check valid taxa when parsing data (GAF column 13; GPI column 7) #2061
Comments
Proposal: if taxon cannot be extracted for whatever reason, the annotation should be removed as a GORULE:0000001 violation. Noting that, since the most likely cause was probably a GPI/GPAD mismatch, the error could even take place while emitting lines. |
Noting that this is cleaning already bad data. The preventative aspect is here: #2066 |
Note that we will initially be trying to have this after the 3.10 requirement in ontobio, which we are aiming for the end of the week. If we cannot make that, we'll try some kind of "backport" or other hack to get this done sooner rather than later. |
Now testing on |
@pgaudet Issues should only be in a single project. As this was already in QC and now clearing, I'm pulling this out of GORULES. @mugitty / @dustine32 Can you confirm that this is correct now on |
Taxon=0 has been observed: geneontology/pipeline#239 (comment)
This should not be allowed; ideally the allowed taxa should come from the taxa loaded (if this is doable)
The text was updated successfully, but these errors were encountered: