Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec out gorule-0000051 : binding and protein binding need 'with' (or extension) #2058

Open
pgaudet opened this issue Aug 31, 2023 · 7 comments

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Aug 31, 2023

  • 'GO:0005515 protein binding' >>> UniProt or a MOD ID (FlyBase:, WB:; RGD:; etc) maybe use dbxref as a start??
  • 'GO:0005488 binding' >> CHEBI

We could consider making the first implementation 'column should not be null' if this is too complicated.

(We will look at GO:0008283 cell population proliferation' later, since this information has not been provided by contributing groups)

@pgaudet pgaudet added this to In progress in GORULES (low-hanging fruit) Aug 31, 2023
@pgaudet pgaudet changed the title First implemntation gorule-0000051 First implementation gorule-0000051 Aug 31, 2023
@pgaudet
Copy link
Contributor Author

pgaudet commented Sep 14, 2023

This should be on snapshot later today

@pgaudet pgaudet self-assigned this Sep 14, 2023
@pgaudet
Copy link
Contributor Author

pgaudet commented Sep 21, 2023

Implemented on shapshot; need to check the GAF test to make sure all rules are correctly failing.

@pgaudet pgaudet moved this from In progress to Clearing in GORULES (low-hanging fruit) Sep 21, 2023
@pgaudet
Copy link
Contributor Author

pgaudet commented Sep 26, 2023

Test GAF working as expected.

@pgaudet pgaudet closed this as completed Sep 26, 2023
@pgaudet pgaudet moved this from Clearing to Done in GORULES (low-hanging fruit) Sep 26, 2023
@pgaudet
Copy link
Contributor Author

pgaudet commented Mar 28, 2024

Not in the reports anymore !

@pgaudet pgaudet reopened this Mar 28, 2024
@pgaudet
Copy link
Contributor Author

pgaudet commented Mar 28, 2024

@pgaudet
Copy link
Contributor Author

pgaudet commented Mar 28, 2024

It was in the October release error report:
http:https://release.geneontology.org/2023-10-09/reports/assigned-by-gorule-report.html

@pgaudet
Copy link
Contributor Author

pgaudet commented Mar 28, 2024

Oups it was commented out on purpose, see #2124

We need to clarify whether this information should be in the extensions or in the with/from (or both)

@pgaudet pgaudet moved this from Done to To spec out & prioritize in GORULES (low-hanging fruit) Mar 28, 2024
@pgaudet pgaudet changed the title First implementation gorule-0000051 Spec out gorule-0000051 : binding and protein binding need 'with' (or extension) Mar 28, 2024
@pgaudet pgaudet moved this from To spec out & prioritize to In progress in GORULES (low-hanging fruit) May 16, 2024
@pgaudet pgaudet moved this from In progress to TODO in GORULES (low-hanging fruit) May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants