Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered goa_uniprot_all_noiea.gaf file does not contain any kind of header; add "edited" header comment to goa_uniprot_all.gaf #1753

Open
kltm opened this issue Nov 2, 2021 · 2 comments

Comments

@kltm
Copy link
Member

kltm commented Nov 2, 2021

In the release pipeline, the filtered noiea product of the goa_uniprot_all.gaf does not have a header. Minimally, it should have !gaf-version: 2.2; ideally, the usual pass-through notice (although that's handled by ontobio which we do not use here).

My guess is that the filter script is literally line matching based on species. I suspect adding a comment pass-through for the filter would fix this. As well, literally doing something like echo, cat, rm, and mv.

I'd also note that this would go away naturally with the species reorientation.

From geneontology/helpdesk#361

@kltm
Copy link
Member Author

kltm commented Nov 9, 2022

This is data (format) integrity.

@kltm
Copy link
Member Author

kltm commented Mar 1, 2023

Also, from @cmungall : add a comment to goa_uniprot_all that we are filtering the "canonical species" list and that this has been processed from the upstream.

@kltm kltm changed the title Filtered goa_uniprot_all_noiea.gaf file does not contain any kind of header Filtered goa_uniprot_all_noiea.gaf file does not contain any kind of header; add "edited" header comment to goa_uniprot_all.gaf Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant