Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with EcoCyc GAF #1541

Open
pgaudet opened this issue Aug 3, 2020 · 6 comments
Open

Issue with EcoCyc GAF #1541

pgaudet opened this issue Aug 3, 2020 · 6 comments
Assignees

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Aug 3, 2020

Hi @dsiegele

  1. There is a problem with the EcoCyc GAF : The database name (col1) uses UniProt, instead of UniProtKB.

This means that we end up with two pages in AmiGO for the same entry:
https://amigo-staging.geneontology.io/amigo/gene_product/UniProtKB:P0A6X7 -> 2 IBA annotations
https://amigo-staging.geneontology.io/amigo/gene_product/UniProt:P0A6X7 -> 36 other annotations

Can you please edit the file and submit a new one ? And please also check the data in the withcolumn.

Only the assigned_bycolumn should have UniProt(Column 15)

Thanks, Pascale

@kltm

@pgaudet
Copy link
Contributor Author

pgaudet commented Aug 3, 2020

  1. Can you also please correct COLLECTF to CollecTF?

Thanks, Pascale

@dsiegele
Copy link

Will fix these. Sorry, I misunderstood feedback in issue #1426 and changed all the instances of UniProtKB to UniProt.

"2. gorule-0000027 Each identifier in GAF is valid
~ 5000 errors
UniProtKB should be changed to UniProt"

@dsiegele
Copy link

@pgaudet @kltm

I edited the file and submitted a new one. Debby

@pgaudet
Copy link
Contributor Author

pgaudet commented Aug 10, 2020

Thanks @dsiegele

I see that the file has no header - according to the documentation (http:https://geneontology.org/docs/go-annotation-file-gaf-format-2.1/) the file needs at least the gaf version number:

!gaf-version: 2.1
(or as appropriate).

I'll let @kltm comment on whether we can parse the file without this info.

Thanks, Pascale

@pgaudet pgaudet self-assigned this Aug 10, 2020
@kltm
Copy link
Member

kltm commented Aug 10, 2020

@dsiegele @pgaudet I believe that we'll be able to parse this either way. I'll start a re-run now.

Tagging @dougli1sqrd

@dsiegele
Copy link

@pgaudet @kltm OK. I'll try to figure out what I did to mess up the header and not do it again next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants