Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to specify that has_input and has_output should be different molecular entities? #27

Closed
vanaukenk opened this issue Jul 11, 2019 · 11 comments

Comments

@vanaukenk
Copy link
Contributor

For a given Molecular Function, do we want to check that the values of 'has input' and 'has output' are different?

Are there cases where that wouldn't be true, either biologically or because the IDs available for 'has input' and 'has output' aren't specific to, say, modified forms of a protein (in which case I'm not sure we'd want to capture this information at all).

@pgaudet
Copy link
Contributor

pgaudet commented Jul 11, 2019

That sounds like a rule rather than a specification of the model ? (or maybe it's the same?)

@ukemi
Copy link

ukemi commented Jul 11, 2019

But that isn't going to always be the case in our modeling. Take the Reactome imports for example. We have decided to allow the same generic entity to represent a protein and a modified form (for now). That specification is coming later.

@ukemi
Copy link

ukemi commented Jul 11, 2019

At least I think that is still the case. With the new representation, behind the scenes the entities might in fact be different since they are in Reactome.

@ukemi
Copy link

ukemi commented Jul 12, 2019

Looking at the Pink/Parkin Mediated Mitophagy model where the PINK1 is cleaved, it does now look like the intact and cleavage product are specified differently (5205671, 5205678). But as you said above, will there be groups that won't necessarily be able to make isoform/modified form distinctions?

@pgaudet
Copy link
Contributor

pgaudet commented Jul 12, 2019

We have decided to allow the same generic entity to represent a protein and a modified form (for now).

If you cannot specify anything different, I would suggest to leave the output blank ? Or is it used as 'provides direct input' for the next reaction'? But I thought that was the previous MF that did that, not the input.

?
Pascale

@deustp01
Copy link

For a given Molecular Function, do we want to check that the values of 'has input' and 'has output' are different?

If subcellular locations are not recorded, the inputs and outputs of many transport functions are indistinguishable. But for this case there is the mechanical workaround of simply excluding annotations to those classes of transport functions from the check.

@deustp01
Copy link

If you cannot specify anything different, I would suggest to leave the output blank ?

I'm probably not understanding this, because it looks to me like this suggestion would have all annotations of protein kinase activity functions as having no output, and many of those phosphorylated outputs are required inputs for later steps in signaling cascades.

@ukemi
Copy link

ukemi commented Jul 12, 2019

Or are the active enablers in the downstream steps.

@huaiyumi
Copy link

Since GO-CAM is not going to model protein modifications, most of the reactions in regulatory pathway will have the same ID. Therefore, I don't think this rule is useful in the spec.
On the other hand, has_input and has_output should be avoided in regulatory pathways.

@ukemi
Copy link

ukemi commented Jul 17, 2019

MGI curators have been adding modified proteins to models using PRO identifiers, as well as annotating modified and processed forms using PRO identifiers for quite some time. See http:https://noctua.berkeleybop.org/editor/graph/gomodel:5ce58dde00001412

@cmungall
Copy link
Member

I think we can close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants