Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GP located_in CC error #254

Open
tmushayahama opened this issue Jan 13, 2021 · 5 comments
Open

GP located_in CC error #254

tmushayahama opened this issue Jan 13, 2021 · 5 comments

Comments

@tmushayahama
Copy link

Dustin and I were looking at a model and It says "GP located_in CC" is wrong and must be Anatomical Entity. However isn't CC an Anatomical entity?

image

tag @dustine32 @vanaukenk @ukemi @pgaudet

@balhoff
Copy link
Member

balhoff commented Jan 13, 2021

Some CCs are anatomical entities, but not all. Only the ones under 'cellular anatomical entity'.

@ukemi
Copy link

ukemi commented Jan 13, 2021

This is an interesting conundrum for root annotations. When the annotation is to the root and the evidence is ND the default relation should be is_active_in (RO:0002432).

https://github.com/geneontology/geneontology.github.io/blob/issue-go-annotation-2917-gaf-2_2-doc/_docs/go-annotation-file-gaf-format-22.md

I thought we had already changed that in our file. Please let me know if we haven't and let us know if this doesn't pass the ShEX.

@vanaukenk
Copy link
Contributor

@balhoff
Following up on the 2021-02-22 ontology editors' call, when you have time, can we take a look at the ShEx together to add root CC (exactly, not root CC or children) as an allowed value for CC annotations where applicable in the schema?

Thx.

@balhoff
Copy link
Member

balhoff commented Mar 4, 2021

This is probably addressed by #259, but that PR only dealt with is_active_in. Does the form editor need to be updated to use the new relation?

@vanaukenk
Copy link
Contributor

@balhoff Thx for your help with the ShEx yesterday.
Yes, the form needs to be update for that relation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants