Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distortion correction code zero pads around array edge instead of NaNs outside of FOV #84

Open
dsavransky opened this issue Aug 5, 2016 · 1 comment

Comments

@dsavransky
Copy link
Contributor

Noticed this when looking at some datacubes - the distortion correction code appears to leave a partial border of pixels with value=zero around the outer edge of the array, which should be all NaNs since it's well outside the field of view. Probably does not matter in practice but since there are no DQ extensions on podc cubes (yet?) the distinction of valid vs. invalid lenslets is based on NaNs so strictly speaking these should be NaNs not zeros.

Attached image shows the partial border around the outside edge of the 281x281 array. But in practice this seems fairly negligible.

@dsavransky
Copy link
Contributor Author

Recovering rm journals for issue:

kfollette: Since this is low priority, I'm setting the target version to 1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants