Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoreducer doesn't do manual flexure shifts if using "Specific recipe" #107

Open
semaphoreP opened this issue Feb 13, 2017 · 1 comment

Comments

@semaphoreP
Copy link
Contributor

Title summarizes it. Autoreducer gives two options: 1. Default automatic recipe 2. Specific recipe. If specific recipe is selected, the manual DX/DY fields for flexure compensation don't get passed to the recipe but appear to the user to be type-able. This can be confusing during the night when we're busy observing and get confused why the pipeline isn't working. We should either:

  1. Don't let users type into DX/DY if "Specific recipe" is selected (easier, probably)
  2. Program it to pass DX/DY flexure fields for "Specific recipe" mode (I'm guessing this is harder.
@mperrin
Copy link
Contributor

mperrin commented Feb 13, 2017

Actually I think option 2 may be easy. The "Specific recipe" option is implemented in an else block at https://github.com/geminiplanetimager/gpi_pipeline/blob/master/drf_guis/automaticreducer__define.pro#L279
That block is 3 lines long and consists solely of looking up the template filename from the GUI drop down. Completely ignores flexure of any kind. I suspect it should be sufficient to modify that to set should_apply_flexure_update=1 if there are nonzero DX and DY values. Or maybe just add it all the time? Setting that variable flags some other code to get invoked later, and that later block appears to be smart enough and have error checking so it won't bomb out if you try it on some template that it doesn't make sense on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants