Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover not good in mobile #839

Open
tienlx97 opened this issue May 10, 2023 · 4 comments
Open

Popover not good in mobile #839

tienlx97 opened this issue May 10, 2023 · 4 comments

Comments

@tienlx97
Copy link

Bug report 🐞

Version & Environment

  • Version of browser: chorme
  • Version of geist-ui/core: latest

Expected Behaviour

The behavior I expect is popover not overflow / hidden

Actual results (or Errors)

I got an error: when I display button left or right screen. The popover will hidden if it out of screen

image

() => {
  const content = () => (
    <>
      <Popover.Item title>
        <span>User Settings</span>
      </Popover.Item>
      <Popover.Item>
        <Link href="#">A hyperlink</Link>
      </Popover.Item>
      <Popover.Item>
        <Link color href="#">A hyperlink for edit profile</Link>
      </Popover.Item>
      <Popover.Item line />
      <Popover.Item>
        <span>Command-Line</span>
      </Popover.Item>
    </>
  )
  return (
    <Popover content={content}>
      Menu
    </Popover>
  )
}
@smyja
Copy link

smyja commented Jul 22, 2023

Bug report 🐞

Version & Environment

* Version of browser: chorme

* Version of `geist-ui/core`: latest

Expected Behaviour

The behavior I expect is popover not overflow / hidden

Actual results (or Errors)

I got an error: when I display button left or right screen. The popover will hidden if it out of screen

image

() => {
  const content = () => (
    <>
      <Popover.Item title>
        <span>User Settings</span>
      </Popover.Item>
      <Popover.Item>
        <Link href="#">A hyperlink</Link>
      </Popover.Item>
      <Popover.Item>
        <Link color href="#">A hyperlink for edit profile</Link>
      </Popover.Item>
      <Popover.Item line />
      <Popover.Item>
        <span>Command-Line</span>
      </Popover.Item>
    </>
  )
  return (
    <Popover content={content}>
      Menu
    </Popover>
  )
}

did you resolve this?

@tienlx97
Copy link
Author

@smyja I resolve by using another library ( fluentui 9 - Microsoft )

@smyja
Copy link

smyja commented Jul 22, 2023

@smyja I resolve by using another library ( fluentui 9 - Microsoft )

Okay 👍🏽

@fitrahmunir
Copy link

Hi @tienlx97 can you review my PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants