Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade nom 6 -> 7 #240

Merged
merged 1 commit into from
Aug 23, 2023
Merged

chore: upgrade nom 6 -> 7 #240

merged 1 commit into from
Aug 23, 2023

Conversation

boxdot
Copy link
Contributor

@boxdot boxdot commented Jun 29, 2023

In particular, this fixes the following warning:

warning: the following packages contain code that will be rejected by a future version of Rust: nom v6.1.2

@boxdot boxdot mentioned this pull request Jun 29, 2023
Merged
Garvys
Garvys approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@Garvys Garvys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey ! Thanks for contributing to rustfst ! :-)

This PR looks good to me. Thanks !

@Garvys
Copy link
Collaborator

Garvys commented Aug 21, 2023

Can you add a dummy commit so that triggers a CI ?
It seems Workflow runs that have been awaiting approval for more than 30 days are automatically deleted.
https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
Sorry that's my fault 😅

@Garvys Garvys merged commit b7da6ee into garvys-org:main Aug 23, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garvys Garvys Garvys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boxdot @Garvys