Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal not working properly after adding pagination #8

Open
anniewey opened this issue Dec 19, 2018 · 1 comment
Open

Modal not working properly after adding pagination #8

anniewey opened this issue Dec 19, 2018 · 1 comment

Comments

@anniewey
Copy link
Contributor

anniewey commented Dec 19, 2018

@garrettmac Any idea why the modal reopen and got stuck after I set visible = false? Tried the same flow without adding pagination and it works properly.

Flow:

  1. Render pagination and modal
  2. Open modal
  3. Close modal
  4. *Modal reopen and screen freeze if pagination component presents
@anniewey
Copy link
Contributor Author

anniewey commented Dec 19, 2018

Update:

Seems like the culprit is animation conflict between Modal and Pagination component. After remove LayoutAnimation.configureNext(dotAnimation); in ./react-native-pagination/index.js, Modal is working properly.

@garrettmac PR is submitted to modify the animation props to optional, do make your review. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant