check-types: add exemptTagContexts option
#461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
force-pushed
the
exemptTagContexts
branch
4 times, most recently
from
44ec029
to
a9bd614
Compare
…ecking (certain types or any types) on specific tags; fixes gajus#255
brettz9
force-pushed
the
exemptTagContexts
branch
from
a9bd614
to
65d8fbc
Compare
|
🎉 This PR is included in version 18.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@brettz9 Was there some/any issue with using expressions? Having to specify the exact match means that custom types can't be used without an inline disable or editing the eslintrc like: {
"jsdoc/check-types": [
2,
{
"exemptTagContexts": [
{
"tag":"type",
"types":[
"Object.<string, string>",
"Object.<string, object>",
"Object.<string, number>",
"Object.<string, boolean>",
"Object.<string, SomeCustomType>",
"Object.<string, Flower>"
]
}
]
}
],
}vs, e.g., {
"jsdoc/check-types": [
2,
{
"exemptTagContexts": [
{
"tag":"type",
"types":[ "Object.<*, *>" ]
}
]
}
],
} |
|
@binury : No guarantees I'll get to looking into it, but should be best to file as a separate issue so this doesn't get lost... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(
check-types): add optionexemptTagContextsto exempt type-checking (certain types or any types) on specific tags; fixes #255