Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time zone info format detection could be more accurate #214

Closed
gabriel-vasile opened this issue Dec 10, 2021 · 1 comment · Fixed by #237
Closed

Time zone info format detection could be more accurate #214

gabriel-vasile opened this issue Dec 10, 2021 · 1 comment · Fixed by #237
Labels
help wanted Extra attention is needed

Comments

@gabriel-vasile
Copy link
Owner

Right now the check is:

TzIf = prefix([]byte("TZif"))

This is a lot of room for false positives with this check.

Solution:
https://tools.ietf.org/id/draft-murchison-tzdist-tzif-00.html#rfc.section.3

@gabriel-vasile gabriel-vasile added the help wanted Extra attention is needed label Dec 10, 2021
@n-vr
Copy link
Contributor

n-vr commented Jan 24, 2022

Hello @gabriel-vasile!

I am trying to contribute more to open source projects, so I created a PR to fix this issue for you. Ofcourse, feel free to do whatever you please with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants