-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/run/lock/power_override/fwupd.lock occasionally left on ChromeOS #7188
Comments
I think that's priority #1 to fix! Do you happen to have any kind of backtrace or daemon
I think on update failure we actually do try to do just that; see https://github.com/fwupd/fwupd/blob/main/src/fu-engine.c#L3365 Although if fwupd actually crashed we'd never get a chance to do the cleanup. I wonder if that's something we could do in the upstart script, e.g. like systemd can do (e.g. Another alternative {workaround?} would be to delete the lockfile when starting fwupd -- on the assumption we're actually auto-starting fwupd after the failed update. |
Unfortunately, our current systems in the field do not upload the fwupd.log file, and I have not reproduced this in an environment where I can get verbose logs. Thanks for the suggestion to add a cleanup to the upstart script --- I will do that! (The lockfile was preventing a system reboot.) |
I also think that powerd should also read the contents of this file and check of the PID (the integer in the file) is still alive... |
Describe the bug
On ChromeOS,
fwupd
1.9.7 may crash when updating Logitech Rally Bar Mini to 1.10.369. On ChromeOS,fwupd
may integrate withpowerd
, and after the crash, leaves a lockfile/run/lock/power_override/fwupd.lock
for days, long after thefwupd
update process is likely no longer running.(Google internal bug reference: b/328243112)
Steps to Reproduce
Across the fleet of Chromebox-for-Meetings, we have seen multiple devices with a Logitech Rally Bar Mini, attempting and failing to update firmware to 1.10.369, and then logging:
INFO powerd: [daemon.cc(1812)] Postponing shutdown for lockfile(s): /run/lock/power_override/fwupd.lock
.This has occurred since R114-15437.59.32. It does not happen on every Logitech Rally Bar Mini. We have not reproduced this behavior in a controlled/developer environment.
Expected behavior
In most cases, the Logitech Rally Bar Mini firmware update to 1.10.369 succeeds, and no
/run/lock/power_override/fwupd.lock
lockfile is left behind.If the update fails, we would like
fwupd
to tellpowerd
to clean up the lock file.fwupd version information
1.9.7
Please note how you installed it (
apt
,dnf
,pacman
, source, etc):On ChromeOS, I believe
fwupd
is installed as a gentoo package.**fwupd device information**
Please provide the output of the fwupd devices recognized in your system.
Additional questions
The text was updated successfully, but these errors were encountered: