Browser builds with node polyfills does not work with .mjs files

[ganemone]

Browser builds with node polyfills does not work with .mjs files

Type of issue

Bug

Description

If a browser file has an .mjs extension and uses a node builtin (e.g. process), and the project has the process polyfill configured, the compiled code will reference require rather than __webpack_require__. This causes an uncaught exception in the browser since require is not defined.

NOTE: There are likely many other issues with .mjs files. We should take verify that other aspects of the build process work with .mjs files.

Current behavior

Generates code using require:

/* WEBPACK VAR INJECTION */}.call(this, require("./../../node_modules/node-libs-browser/mock/process.js")))

Expected behavior

Should generate code using webpack_require:

/* WEBPACK VAR INJECTION */}.call(this, __webpack_require__(/*! ./../node_modules/node-libs-browser/mock/process.js */ "./node_modules/node-libs-browser/mock/process.js")))

Steps to reproduce

1. Scaffold a fusion project
2. Update the package.json to have:

{
  "node":  {
    "process": true,
    "Buffer": true
  }
}

3. Add a file: test.mjs with the following contents

export default function test() {
  console.log(process)
}

4. import and use the test function in src/main.js

import test from './test.mjs';
test();

5. run fusion dev

[rtsao]

Looks like webpack/webpack#7032

[dmaevac]

I see this issue too when trying to use graphql from react-apollo

Example:

import { graphql } from 'react-apollo'
graphql()

causes

Uncaught ReferenceError: process is not defined

[KevinGrandon]

I see this issue too when trying to use graphql from react-apollo

We're going to work on this soon. What version of graphql are you using? I think that particular issue should be resolved in [email protected].

[dmaevac]

@KevinGrandon you a re quite right, adding a resolution to my package.json for 14.0.0 resolved the issue for now.

"resolutions": { "graphql": "14.0.0" }

I was using the version specified by react-apollo which I believe is ^0.13.2