Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide and interface to query and fragments #194

Open
ap-- opened this issue Feb 18, 2024 · 1 comment
Open

Provide and interface to query and fragments #194

ap-- opened this issue Feb 18, 2024 · 1 comment
Labels
enhancement 🚀 New feature or request help wanted 🙏 Extra attention is needed

Comments

@ap--
Copy link
Collaborator

ap-- commented Feb 18, 2024

We need an interface to uri query parameters and fragments.

Could be:

class UPath(...):

    @property
    def query(self) -> Mapping[str, str]:
        ...

    @property
    def fragment(self) -> str:
        ...

    def with_query(self, **params: Any) -> UPath:
        ...

    def with_fragment(self, fragment: str) -> UPath:
        ...
@ap-- ap-- added enhancement 🚀 New feature or request help wanted 🙏 Extra attention is needed labels Feb 18, 2024
@ap--
Copy link
Collaborator Author

ap-- commented Feb 18, 2024

Once this is implemented we can deprecate ._url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request help wanted 🙏 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant