-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several LUA Errors in case with new AFFIX ? Afflicted #238
Comments
I am also getting spammed with Lua errors whenever mousing over the new affix nameplates. |
I get the following randomly in keys: 34x TipTac/ttCore.lua:2403: calling 'IsShown' on bad self (Usage: local isShown = self:IsShown()) Locals: And after that, when trying to mouseover a broker addon: 65x TipTac/ttCore.lua:1530: calling 'GetScale' on bad self (Usage: local frameScale = self:GetScale()) Locals: |
This still exists :( |
Is there an easy way to reproduce this outside of a dungeon? |
No, it only happens with the Afflicted mobs. Maybe TipTac can disable their tooltips if the mob is NPC ID |
Yes is there and it's mostly in M+ Dungeons with Afflicted MOBS. |
New information |
Still happening :( any chance of a workaround? |
Still happening. 71x TipTac/ttCore.lua:1565: calling 'GetScale' on bad self (Usage: local frameScale = self:GetScale()) Locals: |
Could we please have at least a workaround for this, something like the one suggested above? |
From: BNS333 This error often occurs in the Retail, appears in the mythic+ combat. After that, there will be a few Tiptac errors, but it may be affected by this.
|
Can we please prioritze this a bit more? Makes the addon unusable during certain weeks. |
I've been playing WoW the last year only if I have to develop something for TipTac, e.g. new features, fixes or fixes regarding WoW patches. Yesterday I setup my addons/talents and started with actual playing again. I analyzed this specific error several times, but I can't see any obvious error with the coding here. To analyze it further, I have to debug this for myself, and that's only possible if I e.g. go in mythic dungeons. But my main char is currently at lvl 62, so I firstly have to level him up. 🙈 But I'm on it... |
Sorry if I sounded harsh, I just love the addon and I'm sad when it breaks. I really appreciate your efforts. <3
I think what is going wrong is that those particular nameplates are completely protected and cannot be modified by addons in any way and since TipTac tries to attach a tooltip to them it throws protected errors at us. I think there needs to be some kind of check to see if the frame is protected or not and then just cancel trying to attach/modify the tooltip attached to it. The NPC ID is It will be 6 weeks until the affix is back again (it's up for two out of ten weeks in a set rotation of affixes) and you have to be in a +7 or higher key to see it. If you are on EU I would be happy to provide you with a key for testing next time it's up assuming you have a level 70 character by then. |
So I don't now why I didn't see earlier that it only happens with the diff --git a/TipTac/ttCore.lua b/TipTac/ttCore.lua
index f2feeb1..f5c636e 100755
--- a/TipTac/ttCore.lua
+++ b/TipTac/ttCore.lua
@@ -418,7 +418,7 @@ TT_ExtendedConfig.tipsToModify = {
end
},
["EmbeddedItemTooltip"] = { applyAppearance = true, applyScaling = true, applyAnchor = true },
- ["NamePlateTooltip"] = { applyAppearance = true, applyScaling = true, applyAnchor = true },
+ -- ["NamePlateTooltip"] = { applyAppearance = true, applyScaling = true, applyAnchor = true },
["BattlePetTooltip"] = { applyAppearance = true, applyScaling = true, applyAnchor = true },
["FloatingBattlePetTooltip"] = { applyAppearance = true, applyScaling = true, applyAnchor = true },
["FloatingPetBattleAbilityTooltip"] = { applyAppearance = true, applyScaling = true, applyAnchor = true }, diff --git a/TipTacItemRef/ttItemRef.lua b/TipTacItemRef/ttItemRef.lua
index b6068e9..42fe87a 100644
--- a/TipTacItemRef/ttItemRef.lua
+++ b/TipTacItemRef/ttItemRef.lua
@@ -142,7 +142,7 @@ local tipsToModify = {
"ItemRefShoppingTooltip1",
"ItemRefShoppingTooltip2",
"EmbeddedItemTooltip",
- "NamePlateTooltip",
+ -- "NamePlateTooltip",
"BattlePetTooltip",
"PetBattlePrimaryUnitTooltip",
"FloatingBattlePetTooltip", Question now is how easy it is to add a check if a Tooltip is Protected or Forbidden and not to modify. |
This is still happening and the above change didn't fix it for me, in fact made it worse by causing several other addons having a lot of other LUA errors. |
Still happening 50 times every dungeon :( |
I added several |
Turns out it was another addon doing it lately, it just didn't occur to me to check again because this was always the one doing this error (the other one introduced this recently). |
Get this Errors when i dispel the ADDS and tanke them in target ?
TipTac Version 23.05.20
6x TipTac/ttCore.lua:1530: calling 'GetScale' on bad self (Usage: local frameScale = self:GetScale())
[string "=[C]"]: in function
GetScale' [string "@TipTac/ttCore.lua"]:1530: in function
SetScaleToTip'[string "@TipTac/ttCore.lua"]:1650: in function
?' [string "@TipTac/libs/LibFroznFunctions-1.0-10/LibFroznFunctions-1.0.lua"]:885: in function
FireGroupEvent'[string "@TipTac/ttCore.lua"]:1472: in function
SetCurrentDisplayParams' [string "@TipTac/ttCore.lua"]:1336: in function <TipTac/ttCore.lua:1335> [string "=[C]"]: in function
Show'[string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:391: in function <SharedXML/Tooltip/TooltipDataHandler.lua:339>
[string "=[C]"]: in function
securecallfunction' [string "@SharedXML/Tooltip/TooltipDataHandler.lua"]:336: in function <SharedXML/Tooltip/TooltipDataHandler.lua:335> [string "=(tail call)"]: ? [string "=[C]"]: ? [string "=[C]"]: in function
setFunction'[string "@Blizzard_NamePlates/Blizzard_NamePlates.lua"]:860: in function <...eBlizzard_NamePlates/Blizzard_NamePlates.lua:853>
Locals:
Skipped (In Encounter)
Then:
3x TipTac/ttCore.lua:1375: calling 'IsShown' on bad self (Usage: local isShown = self:IsShown())
[string "=[C]"]: in function
IsShown' [string "@TipTac/ttCore.lua"]:1375: in function <TipTac/ttCore.lua:1374> [string "=[C]"]: ? [string "=[C]"]: ? [string "=[C]"]: in function
SetOwner'[string "@Blizzard_NamePlates/Blizzard_NamePlates.lua"]:854: in function `UpdateTooltip'
[string "*Blizzard_NamePlates.xml:351_OnUpdate"]:8: in function <[string "*Blizzard_NamePlates.xml:351_OnUpdate"]:1>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: ?
Locals:
Skipped (In Encounter)
This:
3x TipTacItemRef/ttItemRef.lua:2487: Attempt to access forbidden object from code tainted by an AddOn
[string "=[C]"]: in function
AddLine' [string "@TipTacItemRef/ttItemRef.lua"]:2487: in function
spell'[string "@TipTacItemRef/ttItemRef.lua"]:631: in function <TipTacItemRef/ttItemRef.lua:619>
[string "=[C]"]: ?
[string "=[C]"]: in function `setFunction'
[string "@Blizzard_NamePlates/Blizzard_NamePlates.lua"]:860: in function <...eBlizzard_NamePlates/Blizzard_NamePlates.lua:853>
Locals:
Skipped (In Encounter)
The text was updated successfully, but these errors were encountered: