Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Support for Xiaomi MI Router 4a Gigabit Edition v2 #3291

Closed
ChristianMiddendorf opened this issue Jun 23, 2024 · 4 comments · Fixed by #3293
Closed

Please add Support for Xiaomi MI Router 4a Gigabit Edition v2 #3291

ChristianMiddendorf opened this issue Jun 23, 2024 · 4 comments · Fixed by #3293

Comments

@ChristianMiddendorf
Copy link
Contributor

Hello,
please add the following section into the file ramips-mt7621 to get the new Xiaomi MI Router 4a Gigabit Edition v2 supported.
It works at least with Gluon V2023.2.3 with the settings for Freifunk Ingolstadt. Completed file based on V2023.2.3 added as .zip.

device('xiaomi-mi-router-4a-gigabit-edition-v2', 'xiaomi_mi-router-4a-gigabit-v2', {
factory = false,
})

ramips-mt7621.zip

@herbetom
Copy link
Contributor

herbetom commented Jun 24, 2024

Sorry, i'm not really willing to open a kinda random zip. It would be best to open a Pull Request.

A mandatory requirement for inclusion is a filled out copy of our checklist:

https://github.com/freifunk-gluon/gluon/wiki/Device-Integration

More information on the whole proccess of adding hardware support can be found here:

If you need further help just ask. Either here or via Chat: https://matrix.to/#/#gluon:hackint.org :)

@ChristianMiddendorf
Copy link
Contributor Author

Hello,
a pull is not allowed or i do not know how to get access.
ramips-mt7621.txt
I attached the ramips-mt7621 file with an ending .txt so it just has to be renamed to ramips-7621 after downloading.
supported_devices.rst.txt
The same with the supported_devices.rst file... has to be renamed.
Device-Integration-Checklist-Xiaomi4aGigabitV2.txt
Attached you find the Device Integration Checklist as Textfile.
![Mac_Adress_Proof](https://github.com/fre
Platform_Info
ifunk-gluon/gluon/assets/132701936/a47a2585-a3b1-4a25-8458-6ef0ab9e20b1)
Best regards
Christian

@ChristianMiddendorf
Copy link
Contributor Author

Mac_Adress_Proof

@grische
Copy link
Contributor

grische commented Jun 25, 2024

@ChristianMiddendorf you first need to create a fork:

Once you have a fork, you add the changes to the git repository of the fork and commit it:

Alternatively, you can also just go into your fork on Github and start editing files there within the web browsers. That's quite handy if you have don't want to deal with the git clones and commits.

Once you have commited to changes (either using the git tools or Github web UI), you can open a pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants