Problems with zoom

[Demak]

Hi, found a few problems with zoom policy:

draw2d/src/policy/canvas/WheelZoomPolicy.js

Line 114 in f228358

let scrollHeight = this.canvas.getScrollArea().width()

This line should use height() instead of width()

draw2d/src/policy/canvas/WheelZoomPolicy.js

Line 149 in f228358

if (zoom === canvas.zoomFactor) {

This is always true when canvas dimensions are changed via setDimension here:

draw2d/src/Canvas.js

Line 683 in f228358

this.setZoom(this.zoomFactor, false)

Because of that currently if you call canvas.setDimension when canvas is zoomed, zoom is not applied back after resize, which results in zoom being visually reset, but still applied on canvas coordinates calculation producing wrong results.

[freegroup]

I understand the first part of the ticket (width instead of Height)...but the second part is not clear to me.
Can you please explain it in more detail?

[Demak]

Hi, it was quite a while ago, but as far as I can remember the problem in second part is that in setDimension we are calling this.setZoom with the first argument being zoomFactor of canvas, which after being passed to WheelZoomPolicy's zoom handler is checked for equality with itself in that condition and thus condition will always be true.
Here is a flow:

draw2d/src/Canvas.js

Line 683 in f228358

this.setZoom(this.zoomFactor, false)

draw2d/src/Canvas.js

Line 623 in f228358

this.zoomPolicy.setZoom(zoomFactor, animated)

draw2d/src/policy/canvas/WheelZoomPolicy.js

Line 134 in f228358

this._zoom(zoomFactor, {x: centerX, y: centerY})

draw2d/src/policy/canvas/WheelZoomPolicy.js

Line 149 in f228358

if (zoom === canvas.zoomFactor) {

in the end zoom and canvas.zoomFactor is the same variable. Thus there is no actions from WheelZoomPolicy's zoom handler on changing dimensions and as far as I can remember the problem was that zoom is reset to 1:1 in the start of setDimension but because of that condition was not applied back in the end.

Unfortunately I don't remember how I thought to fix it, haven't worked with draw2d for a while.

[freegroup]

I got it. Try to fix it

[acrimu]

I'm trying to use WeelZoomPolicy but I have some problems.

1. If I try to use

canvas.installEditPolicy(new draw2d.policy.canvas.WheelZoomPolicy({
    onMouseWheel: function(){
      // This is a <span>
      $("#draw2d_canvas_zoom").text(canvas.getZoom());
    }
  }));

I get in console

WheelZoomPolicy.js:159 Uncaught TypeError: Cannot read property 'zoomFactor' of null
    at Class._zoom (WheelZoomPolicy.js:159)
    at step (WheelZoomPolicy.js:137)
    at t.value (shifty.js:2)
    at shifty.js:2

[phiferd]

Not sure if this is the same issue, but there is a bug in the wheel zoom policy.

This line calls _zoom with three parameters (zoom, centerX, centerY):

https://github.com/freegroup/draw2d/blob/master/src/policy/canvas/WheelZoomPolicy.js#L127

But _zoom expects two parameters (zoom, centerPoint).