-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragging both rectangles "breaks" draw2d #109
Comments
Hello please provide more information, it is best to show the code |
Hi, first of all, thanks for the amazing library, it is very nice and intuitive. Summary I can confirm I sometimes get a similar behaviour, when using the Expected Behaviour Dragging a component re-routes the connection "as normal". Actual behaviour The interface becomes unresponsive, the connection becomes a straight line connecting source and target port (instead of being routed like the Manhattan router usually does). This bug requires the application to be restarted. Extra info It looks like the lag-ish behaviour is due to the library code getting stuck into an infinite recursion, which eventually leads to a stack overflow. Here is a screenshot of the error from the Chrome devTools console (sorry about it being a screenshot instead of a copy and paste, this happened last a couple of days ago and I did not think of copying it). By stepping through the code with the devTools debugger, I found out that the issue may be related to the function If this can be useful, here is the function I use to create connections:
Environment I am running draw2d from within an Electron application packaged with Webpack. The Chromium version I am using i 59. I do not expect electron to have anything to do with this issue though. |
Just a comment on this issue. It seems that connections with colinear end-points trigger this. Here is the JSON for a circuit which when loaded and interactivemanhattanconnection routed cases the above (@ms8817) stack problem whenever the right-hand component is dragged. All shapes have relative ports with positions as shown in picture. the shapes as loaded (before the router breaks) are as below The bug happens on any attempt to drag components: the visible component positions do not change and the application becomes unresponsive: The JSON showing port info (and some other stuff not relevant):
The stacktrace info:
|
How to reproduce:
The UI is very laggy and unresponsive, ports are not connected to parent anymore. Only the InteractiveManhattanConnectionRouter triggers this behavior. Disabling SnapToGrid does not fix it.
The text was updated successfully, but these errors were encountered: