New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three.js WebGL - Migrate from Geometry to BufferGeometry #436

Closed

andreasrosdal opened this issue Dec 5, 2021 · 1 comment

Contributor

andreasrosdal commented Dec 5, 2021

The FCW code needs to be migrated to use BufferGeometry instead of Geometry, in order to update to recent Three.js versions.

PlaneGeometry shoud be migrated to BufferGeometry here:
https://github.com/freeciv/freeciv-web/blob/develop/freeciv-web/src/main/webapp/javascript/webgl/mapview.js#L179

FCW currently at Three.js version r124. Latest is r135.

A description about how to do this is documented here:
https://sbcode.net/threejs/geometry-to-buffergeometry/

See #336

Contributor Author

andreasrosdal commented Jul 27, 2022

Fixed in https://www.fciv.net https://github.com/fciv-net/fciv-net

andreasrosdal closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment