-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass fragments/query parameters to the preview iframe #600
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In order to test JavaScript code that uses fragments e.g.
#heading
or query parameters e.g.?param=value
it is currently fairly tedious, you have to inspect the preview iframe and manually update thesrc
, then reload the frame. These changes aren't stored either so refreshing the page loses them.Steps to Reproduce
<script>console.log(window.location.hash);</script>
src
attribute on the preview iframe: the hash is logged. But:Expected behavior: The hash to be passed through to the preview iframe.
Actual behavior: It is not passed through.
Versions
Additional Information
The simple solution to this would be to just pass hashes/query parameters forward, but a possible additional nicety would be to allow defaults to be set via component/variant properties. So you could provide a hash/query in the config e.g.
Notes
Original raised on the core fractal repo: #516
The text was updated successfully, but these errors were encountered: