Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon: yellow is poorly visible on white #166

Closed
532910 opened this issue Apr 24, 2020 · 5 comments
Closed

icon: yellow is poorly visible on white #166

532910 opened this issue Apr 24, 2020 · 5 comments

Comments

@532910
Copy link

532910 commented Apr 24, 2020

image

@frankmorgner
Copy link
Owner

I think yellow on white is good enough. However, the white rectangle on white background is not ideal. What would you suggest as improvement? Could you make a pull request?

@532910
Copy link
Author

532910 commented Apr 25, 2020

#165 is about the white rectangle. But this yellow is really poorly visible and shadow makes it dirty.

The improvement is easy:

  1. Choose a bit darker yellow color
    At least with 2.0 ratio, if you'd like to leave white:
    https://contrastchecker.com/?c=FFFFFF&b=e2ad00
    Rithgt now it's 0xededed/0xfbce17 that has a very low contrast ratio: 1.29.

  2. Make a flat yellow color adaptive foreground.

  3. Remove shadow

  4. Put current symbols in white color on the foreground.

I'd be happy to make a PR, but I have no android studio (I heard that it's required for the easiest adaptive icons creation) or even an android build env.

@532910
Copy link
Author

532910 commented Apr 25, 2020

OK, I've installed android studio, and Image Asset says "Project must be built with SDK 26 or later to use adaptive icons"

Is it easy to upgrade it?

@532910
Copy link
Author

532910 commented Apr 25, 2020

Could you also point me to the current icons in svg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants