Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Animating display from 'block' to 'none' not working since 11.0.11 #2656

Open
dd-jonas opened this issue May 10, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@dd-jonas
Copy link

dd-jonas commented May 10, 2024

1. Read the FAQs 👇

2. Describe the bug

When defining variants with display: block and display: none, the display does not return to none upon triggering the animation.

This worked fine in 11.0.10.

3. IMPORTANT: Provide a CodeSandbox reproduction of the bug

Reproduction

4. Steps to reproduce

Steps to reproduce the behavior:

  1. Go to the sandbox above
  2. Click on the show/hide button to show the overlay
  3. Click on the show/hide button to hide the overlay
  4. Notice that the opacity has animated, but display is still block (notice that the backdrop is still there, because you can't select nay text on the screen)

5. Expected behavior

The overlay should return to display: none as was the case before 11.0.11.

6. Video or screenshots

/

7. Environment details

/

@dd-jonas dd-jonas added the bug Something isn't working label May 10, 2024
@mattgperry
Copy link
Collaborator

Yeah this did get inadvertently broken though the previous behaviour wasn't great either (instantly animating to "none" when you probably want that to happen at the end of the animation)

I'll take a look over the next couple days and see if we can do something where animating display and visibility can be handled more gracefully.

@alex-cortenix
Copy link

Any progress on that??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants