-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vs-shell-format should NOT download shfmt without asking #46
Comments
you can just set the |
IIRC the binary was downloaded even when I set |
👍good suggestion. you can pull request code. |
Hi, OTOH, regarding OP's observation, I'm good with the extension automatically fetching dependencies, unless there's a better way to handle custom installations of Please don't remove this feature :) |
Same issue here. I have {
"shellformat.path": "/usr/local/bin/shfmt",
} But it still downloads Info:
|
fix on v6.1.2 |
I definitely want it to download shfmt for me! It seemed to just do it again even though it was previously installed? Maybe I did not boot vs code for a few days. Using Fedora 29 Linux, latest vs code.
|
@foxundermoon this seems to still download without asking. I agree auto-downloading is super useful for some people, but like the Go extension or others do, it should ask first. IMO It should also not be parsing all my paths to find the binary, if you run |
@pecigonzalo if you don't need auto-download , please set |
@David-Else |
I suggest to bundle the binaries with the extension, this would prevent the extension from "downloading automatically" the files. |
I sync the settings on vscode and I use it on both Windows and Linux. To my surprise I found a binary with the name Most extensions that need an external binary either ask to provide the path if not found, or ask to download the needed tools (eg. go). |
Was this changed? I can't find an entry in the changelog or in the commit log that matches this issue. |
VSCode released support for platform specific extensions. I think it's just what this extension would need. |
I have my package manager to install shfmt and I definitely don't want the extension to fetch any blobs from the Internet. The extension keeps downloading it even when I delete the binary.
The text was updated successfully, but these errors were encountered: