Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: anvil --config-out anvil.json upon completion starts anvil #2512

Closed
2 tasks done
sambacha opened this issue Jul 29, 2022 · 2 comments
Closed
2 tasks done

Bug: anvil --config-out anvil.json upon completion starts anvil #2512

sambacha opened this issue Jul 29, 2022 · 2 comments
Labels
T-bug Type: bug

Comments

@sambacha
Copy link
Contributor

Component

Anvil

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

No response

What command(s) is the bug in?

anvil --config-out anvil.json

Operating System

No response

Describe the bug

when running

usr:~ $ anvil --config-out anvil.json

I expect anvil to output the config to the json file, then quit. Anvil will correctly output to the json file, then it will actually start. I expect anvil not to start when running this command.

@sambacha sambacha added the T-bug Type: bug label Jul 29, 2022
@mattsse
Copy link
Member

mattsse commented Jul 29, 2022

this was the issue #1718
and was added here #1854

I see that this makes it impossible to only get the config without starting it, if we separate running/dumping config it would mean that running + getting config is now a 2step process.

I am not sure what disadvantages this would have or what would be the best solution here, don't have strong feelings about this.

The question may be why you only want to get the json config and not start it.

@sambacha
Copy link
Contributor Author

fair enough, i just thought it odd that generating a config would also start it, just making sure this is intended behavior, we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

No branches or pull requests

2 participants