Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikilinks not Colored in Editor #1169

Open
micharris42 opened this issue Feb 21, 2023 · 4 comments
Open

Wikilinks not Colored in Editor #1169

micharris42 opened this issue Feb 21, 2023 · 4 comments

Comments

@micharris42
Copy link

Describe the bug

Hello, new Foam user here, so I please forgive me if this is actually a non-issue, or if I am reporting it in the wrong place.

I set up a Foam workspace over the weekend, and while everything seems to be working, the wikilinks do not appear to be properly colored in the editor. Instead of blue, they are colored reddish-orange, the same color as code styling.

See below:

Capture1

Strangely, the wikilinks are colored properly in the preview:

Capture2

I have tried to figure this out based on the documentation and the issues already available, but the only solution I could find was to add the setting "foam.decorations.links.enable" and set it to true. However, VSCodium labels this as an "Unknown Configuration Setting", and nothing changes.

I do not know if that means the setting has been retired, or I am trying to use it incorrectly.

I am using Foam 0.21.0 with VSCodium 1.75.1 on Windows 10.

Please let me know if there is any further information I should add, or if there is a more appropriate place for this to be reported.

Thank you.

Small Reproducible Example

No response

Steps to Reproduce the Bug or Issue

  1. Create a wikilink.
  2. The link is not colored corrently.

Expected behavior

That wikilinks be colored to differentiate them from external links.

Screenshots or Videos

No response

Operating System Version

Windows 10

Visual Studio Code Version

VSCodium 1.75.1

Additional context

No response

@riccardoferretti
Copy link
Collaborator

Hi @micharris42
if I understand from the screenshot, the first wikilink links to an existing resource, the second is a placeholder.
The colors are slightly different in the editor, and the color of the wikilink iirc comes from the theme, not Foam.
Changing theme should change that color.

Let me know if that fixes your issue

@micharris42
Copy link
Author

Hello @riccardoferretti, thank you for your answer.

Yes, the screenshot includes both an existing link and a placeholder. I included both to better indicate that the wikilinks were being displayed in reddish-orange and yellow, not blue and yellow as is prominently shown in the Foam documentation. It sounds as though I need to go theme hunting.

If I could have a little more of your time, what is the theme used in the Foam documentation? And additionally, has the setting "foam.decorations.links.enable" been disabled, or have I misunderstood how it is meant to be used?

Thank you.

@riccardoferretti
Copy link
Collaborator

Oh my, I don't remember which theme we used 😅 I currently use a slightly customized version of Dark+

Regarding foam.decorations.links.enable, that's a very good point, we are no longer using the setting.

I am going to think about this a bit more, happy to hear thoughts/suggestions in the meantime by you and other users.

@micharris42
Copy link
Author

Thank you @riccardoferretti, that answers my questions. Will leave this issue open for now, but feel free to close it whenever you think it has served its purpose.

Not sure how much value I can provide, given that I have not even been a Foam user for a full week yet, but the reason I believed there was an issue was because all of the image files on the Foam page on the Visual Studio Marketplace display Foam with blue-colored wikilinks and yellow-colored placeholders. When I installed Foam myself and saw that my wikilinks did not match, I first referred to the Foam documentation, and when I could not find anything there, I turned to earlier GitHub issues, and found the "foam.decorations.links.enable" setting, which has apparently since been deprecated.

The best suggestion I can make is that it be acknowledged somewhere in Foam's documentation that the link styling is determined by the VS Code theme, not by a Foam setting.

Additionally, the VS Code theme used on the marketplace page could also be included in the documentation for users to look up and try, and to go a step further, a recipe could be added explaining how users can customize a theme to highlight the text between square brackets with the color of their choice.

My two cents, anyway.

Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants