Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with paragraph identification #4

Closed
jspalink opened this issue Apr 19, 2019 · 2 comments
Closed

Issues with paragraph identification #4

jspalink opened this issue Apr 19, 2019 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@jspalink
Copy link

It looks like the segmenter. __PARAGRAPH_SEP was recently changed from regex.compile("\r?\n(?:\s*\r?\n)+") to regex.compile("\r?\n(?:\\s*\r?\n)+"). I suspect that's a mistake that snuck in with commit af5d011.

@fnl
Copy link
Owner

fnl commented Apr 21, 2019

That change looks correct to me.
The change in the regex pattern fixes a deprecation warning when running pytest using the old version:
DeprecationWarning: invalid escape sequence \s

Both the old and the new (changed) version work for me using Python 3.6 and 3.7, but the new version no longer produces the deprecation warning.

Though, if you can give me a reproducible error report, I will happy to reopen and investigate this further.

@fnl fnl closed this as completed Apr 21, 2019
@jspalink
Copy link
Author

Ah, my bad. I'm usually using the r prefix on regex strings and was looking at this thinking it's looking for a literal \.

@fnl fnl added question Further information is requested enhancement New feature or request wontfix This will not be worked on and removed question Further information is requested labels Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants