Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting two words joined by ellipsis (...) and no spaces into different tokens #1

Closed
nth-attempt opened this issue Feb 5, 2019 · 2 comments
Closed

Splitting two words joined by ellipsis (...) and no spaces into different tokens #1

nth-attempt opened this issue Feb 5, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@nth-attempt
Copy link

Example:
For the sentence Lalala...or Lala Land...., currently the first output token is Lalala...or. Would it make sense to split this into multiple tokens?
@fnl
Copy link
Owner

fnl commented Feb 6, 2019

Totally agree, this should be spit into three tokens, Lalala, ... and or.

@fnl fnl added the enhancement New feature or request label Feb 6, 2019
@fnl
Copy link
Owner

fnl commented Feb 9, 2019

Released version 1.1.0, that now properly splits tokens with inner ellipses and treats ellipses as proper tokens.

@fnl fnl closed this as completed Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fnl @nth-attempt