Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No alerts on canary non analysis phase failures #1663

Open
macox opened this issue Jun 17, 2024 · 0 comments
Open

No alerts on canary non analysis phase failures #1663

macox opened this issue Jun 17, 2024 · 0 comments

Comments

@macox
Copy link

macox commented Jun 17, 2024

Describe the bug

During a canary deployment there are a number of situations where any configured alerts are not fired when the canary fails:

  • pre-rollout webhook
  • exceeded its progress deadline when (canary/primary) pods not ready

To Reproduce

Configure a canary deployment with suitable alert provider e.g. Slack. Include a pre-rollout webhook that purposely fail.
Despite the canary resulting on a failed state no alert is sent and the end user has no visible of what has happened to their canary deployment

Expected behavior

Alert on:

  • pre-rollout webhook failing
  • exceeded its progress deadline when (canary/primary) pods not ready

Allow these alerts to be muted if required

Additional context

  • Flagger version: v1.37.0
  • Kubernetes version: v1.26
  • Service Mesh provider: Istio
  • Ingress provider: Istio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant