Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPProxy's projectcontour.io/ingress.class gets removed after reconciliation #1539

Open
frekw opened this issue Oct 13, 2023 · 1 comment
Open

Comments

@frekw
Copy link

frekw commented Oct 13, 2023

Describe the bug

When ContourRouter.Reconcile is ran, the projectcontour.io/ingress.class annotation gets removed. I think this is due to the fact that the annotation is only set upon creation, but during update we just grab the annotations and overwrite them, disregarding the fact that they may diff.

To Reproduce

Run flagger with -ingress-class and do a rollout.

Expected behavior

The ingress class to remain.

Additional context

  • Flagger version: 1.33.0
  • Kubernetes version: -
  • Service Mesh provider: Contour
  • Ingress provider: Contour
@KrylixZA
Copy link

I wonder if this is related to #1312 which unfortunately has been open for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants