-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canary is restarted to "Starting canary analysis for podinfo.test" on Confirm Traffic Increase fail #1248
Comments
@andylibrian thanks for opening this issue and showing interest to contribute a fix, I'm assigning you this issue. Feel free to ask for any help/suggestions if needed, looking forward to your PR :) |
@aryan9600 Sure. For the first step, I would like to get a comment / feedback from maintainers, whether what I described is a bug. Is my description on "Expected behavior" correct / agreed? If so, is there any comment on my proposed solution? The one in the "Notes" section. |
Yes, the expected behavior is for analysis to halt till the hooks return a HTTP 2xx response. |
This is to fix fluxcd#1248 where canary is restarted to "Starting canary analysis" on confirm traffic increase failure. Signed-off-by: Andy Librian <[email protected]>
This is to fix fluxcd#1248 where canary is restarted to "Starting canary analysis" on confirm traffic increase failure. Signed-off-by: Andy Librian <[email protected]>
This is to fix fluxcd#1248 where canary is restarted to "Starting canary analysis" on confirm traffic increase failure. Signed-off-by: Andy Librian <[email protected]>
This is to fix fluxcd#1248 where canary is restarted to "Starting canary analysis" on confirm traffic increase failure. Signed-off-by: Andy Librian <[email protected]>
This is to fix fluxcd#1248 where canary is restarted to "Starting canary analysis" on confirm traffic increase failure. Signed-off-by: Andy Librian <[email protected]>
Describe the bug
Given
The canary is always restarted over to "Starting canary analysis"
Thus the pre-rollout webhook is executed repeatedly.
To Reproduce
Expected behavior
As the docs says,
I would expect the canary is paused without being restarted to pre-rollout again.
Additional context
Notes
If this is a bug, I would be happy contribute a fix. I think the problem here is
The
runConfirmTrafficIncreaseHooks
on failure returns with the same Phase: Progressing.flagger/pkg/controller/scheduler.go
Lines 450 to 452 in f449ee1
Then in the next run, this condition is satisfied (canaryWeight: 0, status.Iterations: 0)
flagger/pkg/controller/scheduler.go
Lines 401 to 403 in f449ee1
A possible solution could be to have a dedicated status for
WaitingTrafficIncrease
so that we can exclude this phase from restarting analysis, similar toCanaryPhaseWaitingPromotion
.The text was updated successfully, but these errors were encountered: