Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[photo_manager] Support for limited access: ask for extra images #125

Closed
yanivshaked opened this issue May 9, 2021 · 9 comments
Closed

[photo_manager] Support for limited access: ask for extra images #125

yanivshaked opened this issue May 9, 2021 · 9 comments
Labels
r: photo_manager Related to the photo_manager package. s: feature There's a feature request in this issue.
Milestone
6.0.0

Comments

@yanivshaked
Copy link
Contributor

yanivshaked commented May 9, 2021 •
edited
Loading

Version information

  • Device: iPhone 12 Pro
  • OS: iOS 14.4.2
  • Package Version: v5.4.0+1
  • Flutter Version: v2.0.5

Is your feature request related to a problem?
Yes. On iOS 14, a new model of permission was introduced. The user can select only several pictures from the device's gallery and those pictures are available to the picker.
If the user opens the gallery again, he is NOT asked to give more pictures if he wants.
(See how WhatsApp have solved this issue).

Describe the solution you'd like
It should be possible for the user to bring up the native popup asking for more pictures to be added to the selection.
(This is done using the iOS PHPhotoLibrary.shared().presentLimitedLibraryPicker method)

Additional context
This issue is related to photo_manager and the solution should be joint.
I'm attaching a video that shows the problem:

ExampleSelectiveGallery.mp4

This is how WhatsApp solved this issue (we need something similar):

WhatsAppSelectiveGallery.mp4
@yanivshaked yanivshaked added the await investigate The issue is waiting for further investigation. label May 9, 2021
@github-actions github-actions bot added the await triage The issue is waiting for triage. label May 9, 2021
@AlexV525 AlexV525 added b: third party This is a third party package issue. i: out of support The issue is out of basic support and not a feature request. r: photo_manager Related to the photo_manager package. s: feature There's a feature request in this issue. and removed await investigate The issue is waiting for further investigation. await triage The issue is waiting for triage. labels May 9, 2021
@AlexV525
Copy link
Member

AlexV525 commented May 9, 2021

fluttercandies/flutter_photo_manager#385

@AlexV525 AlexV525 closed this as completed May 9, 2021
@yanivshaked
Copy link
Contributor Author

I think you are too quick closing it; Beside the photo_manager support required, there should be also code supporting it in this plugin.

@AlexV525
Copy link
Member

AlexV525 commented May 9, 2021

It shouldn't, at least for now.

@blackchineykh
Copy link

What should we be doing to handle this situation? I have this issue and i'm not sure what approach to take to resolve it as I have a case where the user has given limited access but there is no way for me to have them change this or go back to selecting other photos

@AlexV525
Copy link
Member

What should we be doing to handle this situation? I have this issue and i'm not sure what approach to take to resolve it as I have a case where the user has given limited access but there is no way for me to have them change this or go back to selecting other photos

Please subscribe fluttercandies/flutter_photo_manager#385 for further implementations.

@yanivshaked
Copy link
Contributor Author

@blackchineykh In general, the photo_manager should support the following:

  • Return a new value indicating the user has used limited photo access.
  • Allow asking the user to select more images using PHPhotoLibrary.shared().presentLimitedLibraryPicker with a new method.
  • Adding the required support for that in this plugin.

@mishatron
Copy link

Why this issue is closed? As described photo_manager 1.2.0 implemented ios 14 limited access. So, please, add ability to open this picker if we have limited access

@AlexV525 AlexV525 reopened this Jun 3, 2021
@AlexV525 AlexV525 added await investigate The issue is waiting for further investigation. i: postpone The issue cannot be solved right away. and removed i: out of support The issue is out of basic support and not a feature request. labels Jun 3, 2021
@AlexV525 AlexV525 added this to the 6.0.0 milestone Jun 3, 2021
@AlexV525 AlexV525 changed the title [iOS 14 Permissions] Support for limited access: ask for extra images [photo_manager] Support for limited access: ask for extra images Jun 3, 2021
@AlexV525
Copy link
Member

AlexV525 commented Jun 3, 2021

This requires to sync with the latest WeChat version (8.x). They will be handled together.

@AlexV525 AlexV525 removed the b: third party This is a third party package issue. label Jun 4, 2021
This was referenced Jun 26, 2021
Merged
Closed
@AlexV525
Copy link
Member

This has been implemented by multiple commits, and will be released along with the 6.0.0 version.

@AlexV525 AlexV525 removed await investigate The issue is waiting for further investigation. i: postpone The issue cannot be solved right away. labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
r: photo_manager Related to the photo_manager package. s: feature There's a feature request in this issue.
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
4 participants
@blackchineykh @yanivshaked @AlexV525 @mishatron